Eric Dumazet e1f2092a94 inet_diag: fix possible overflow in inet_diag_dump_one_icsk() ...

[ Upstream commit c8e2c80d7e ]

inet_diag_dump_one_icsk() allocates too small skb.

Add inet_sk_attr_size() helper right before inet_sk_diag_fill()
so that it can be updated if/when new attributes are added.

iproute2/ss currently does not use this dump_one() interface,
this might explain nobody noticed this problem yet.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

2015-03-24 08:22:19 -04:00

29 KiB

Raw Blame History

View Raw